No vendor quests for Skara Brae

[Sei Ryu]

I went through all the vendors in Skara Brae TWICE, none of them gave me package deliveries for any of the local vendors. I am trying to remember the last time I got a package delivery for someone from Skara Brae, but I can't remember any at all.

Checking at the WoD scripts, it leads me to guess the FindMyTown() function is failing. Check the case for Skara Brae in compile\include\towns.inc:

Code: Select all

	elseif (x >= 530 and x <= 2250 and y >= 2100 and y <= 600)
		return TOWN_SKARA_BRAE;

The 2250 and 600 must be swapped to fix the problem.

[Sei Ryu]

Also, the case for Minoc doesn't feel right to me.

Code: Select all

	elseif (x >= 2400 and x <= 2650 and y >= 2500 and y <= 700)
		return TOWN_MINOC;

The y >= 2500 should be y >= 250

[Laephis]

Thanks, I'll test this out this weekend.

[Sei Ryu]

Lets hope with these two fixes we finally stop getting the "Well, I could... Hmm... No, never mind. Come back later." message while asking for a quest.

[Laephis]

Update: I made the changes to towns.inc, recompiled all the scripts in pkg\npcs\townfolk\merchants, but no vendor quests ever came up for Skara. Maybe there's something more to this issue?

[Sei Ryu]

Maybe restarting the NPC vendors? The quest script looks at a global array of the vendors for each town. Each vendor adds itself to the global array upon vendor startup or vendor restart.

the global array is ("#merchants_of_town_" + chosentown), where chosentown should be 10 for Skara Brae

[Sei Ryu]

Ok, finally found the problem: the compile\include\towns.inc is obsolete, the WoD scripts use scripts\include\locations.inc instead.

Also, the coordinates for Skara Brae are a little off. The correct coordinates are:

Code: Select all

	elseif (x >= 530 and x <= 680 and y >= 2100 and y <= 2290)
		return TOWN_SKARA_BRAE;

I verified the ones for Minoc, they work with the change I suggested:

Code: Select all

	elseif (x >= 2400 and x <= 2650 and y >= 250 and y <= 700)
		return TOWN_MINOC;

[Laephis]

This should be fixed now, let me know if it needs any more tweaking.